New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve `C-FAILURE` violations #3036

Merged

jessebraham merged 3 commits into esp-rs:main from playfulFence:docs/contributing

Jan 28, 2025

Contributor

playfulFence commented Jan 27, 2025

closes #2812
closes #2794
closes #2789
closes #2665

playfulFence added the skip-changelog label

bugadani reviewed

View reviewed changes

esp-hal/src/gpio/mod.rs Outdated Show resolved Hide resolved

JurajSadel reviewed

View reviewed changes

esp-hal/src/gpio/mod.rs Outdated Show resolved Hide resolved

JurajSadel reviewed

View reviewed changes

esp-hal/src/gpio/mod.rs Outdated Show resolved Hide resolved

bugadani reviewed

View reviewed changes

esp-hal/src/gpio/mod.rs Outdated Show resolved Hide resolved

bugadani reviewed

View reviewed changes

esp-hal/src/spi/master.rs Outdated Show resolved Hide resolved

bugadani reviewed

View reviewed changes

esp-hal/src/uart.rs Outdated Show resolved Hide resolved

playfulFence force-pushed the docs/contributing branch from 8c006bf to be4a070 Compare

January 27, 2025 12:46

bugadani reviewed

View reviewed changes

esp-hal/src/i2c/master/mod.rs Outdated Show resolved Hide resolved

playfulFence force-pushed the docs/contributing branch from be4a070 to d200acf Compare

January 27, 2025 13:07

bugadani reviewed

View reviewed changes

esp-hal/src/i2c/master/mod.rs Outdated Show resolved Hide resolved

playfulFence force-pushed the docs/contributing branch from da5d9b3 to 24afabb Compare

January 27, 2025 13:58

playfulFence marked this pull request as ready for review

January 27, 2025 14:16

SergioGasquez approved these changes

View reviewed changes

Member

SergioGasquez left a comment

Changes LGTM, thanks! Just 2 notes on adding a comments on the referenced issues

esp-hal/src/gpio/mod.rs Show resolved Hide resolved

esp-hal/src/spi/master.rs Show resolved Hide resolved

playfulFence requested review from JurajSadel and bugadani

January 27, 2025 16:12

playfulFence added 3 commits

January 28, 2025 09:33


          progress towards C-FAILURE issues

8ddb4d7

fmt


          reviews

dda2487

dumb0


          I2C: FIFO cannot be exceeded

274c2fb

fmt

playfulFence force-pushed the docs/contributing branch from 24afabb to 274c2fb Compare

January 28, 2025 08:33

jessebraham approved these changes

View reviewed changes

jessebraham enabled auto-merge

January 28, 2025 08:49

jessebraham added this pull request to the merge queue

bugadani approved these changes

View reviewed changes

Merged via the queue into esp-rs:main with commit 2ff28b1

28 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels